Stepconf destroy postgui_custom.hal

Hi,
Why stepconf overwrites the postgui_custom.hal file while it leaves untouched custom.hal?
I believe that the problem is here:
First it is overwritten by the backup file and after is still destroyed by open(custom, "w")
Did I do something wrong?

Nicola.

it overwrite the custom post gui file because it allows the users to select options that require changes in the file.
The custom file is not overwritten so custom code will not be destroyed, but unfortunately most code requires to be added after the GUI loads - so most code needs to be in the postgui file.

probably a better way (one that pncconf uses) is have the postgui code call a user hal file after all the machine written code.
This user file would not be overwritten.
Put another way have the postgui file call the custom hal file.

Even better would be to have stepconf smart enough to work around custom code but I think that is just do difficult to do well.

Chris M

Hi Chris,

cmorley wrote: it overwrite the custom post gui file because it allows the users to select options that require changes in the file.

Ok, you're right. So I think this row is useless: Originally maybe someone wanted to save the file and then he left there these lines.

cmorley wrote: probably a better way (one that pncconf uses) is have the postgui code call a user hal file after all the machine written code.
This user file would not be overwritten.
Put another way have the postgui file call the custom hal file.

The easiest way I think is tell of stepconf just append a second file at the end of custom_postgui.hal. Like:
cat user_custom_postgui.hal >> custom_postgui.hal.

Or I can update the ini file to include user_custom_postgui.hal.
1) Do you think I can add additional POSTGUI_HALFILE lines?:
POSTGUI_HALFILE = custom_postgui.hal
POSTGUI_HALFILE = user_custom_postgui.hal

Or can I put other files in same row?:
POSTGUI_HALFILE = custom_postgui.hal; user_custom_postgui.hal

2) Is there a way to call a hal file within another?:
load user_custom_postgui.hal

cmorley wrote: Even better would be to have stepconf smart enough to work around custom code but I think that is just do difficult to do well.

To differentiate the stepconf lines those custom lines, I might add comment lines like many programs, such as:
#### do not remove this line ####

What I do not know is whether there are precedence in command of hal files. In this case I would not know how to handle the lines.

Thanks, Nicola.

Ok, you're right. So I think this row is useless:

Code:

shutil.copy( custom,os.path.join(base,"postgui_backup.hal") )

Originally maybe someone wanted to save the file and then he left there these lines.

This was me it is done so if the user modified the postgui file (like most will) then uses stepconf again
they have a chance to not lose their hard work.

The easiest way I think is tell of stepconf just append a second file at the end of custom_postgui.hal. Like:
cat user_custom_postgui.hal >> custom_postgui.hal.

I think this is risky order of stuff is important.
and if the user continues to edit and re use stepconf you will add it twice or need to add code to check for it...

Or I can update the ini file to include user_custom_postgui.hal.
1) Do you think I can add additional POSTGUI_HALFILE lines?:
POSTGUI_HALFILE = custom_postgui.hal
POSTGUI_HALFILE = user_custom_postgui.hal

Or can I put other files in same row?:
POSTGUI_HALFILE = custom_postgui.hal; user_custom_postgui.hal

Nope.

2) Is there a way to call a hal file within another?:
load user_custom_postgui.hal

Yes this is what i was referring to:
source [some_filename]

cmorley wrote: Even better would be to have stepconf smart enough to work around custom code but I think that is just do difficult to do well.

To differentiate the stepconf lines those custom lines, I might add comment lines like many programs, such as:
#### do not remove this line ####

What I do not know is whether there are precedence in command of hal files. In this case I would not know how to handle the lines.

Thanks, Nicola.

The problem with mixing user code and configuration made code in the same file is the complication that the user is
unpredictably dangerous
I'm sure it can be done.
then one needs to also look at how we offer custom snipits of code as examples.
They always mention the postgui file. better to leave this file for the user to play with alone.
In pncconf the INI calls a postgui 'jumpfile' that jump file has source commands in it.
One source command isused to call postgui.hal.

While slighly more complicated and unusual it separates config made code from user made code pretty well.

Chris M

Hi Chris,

thanks for your answer.
I looked in the documentation but could not find anything about "source" command :blink: But it seems to work.

About pncconf seems to have a much more complex management for hal files. I think I will copy and paste the pncconf code inside stepconf.

Why do not you treated in the same way the stepconf code? Do you hate stepconf? :lol:

Nicola.

man halcmd does show the source command... it's a little used gem.

Stepconf was originally built and maintained by some one else.
His objectives were different then mine - I tried to honour the differences when I updated to newer glade files.

Pncconf was my baby so I was free to do as I pleased - right or wrong

I'm a little tired of both so am glad you are interested !
It's a very import part of linuxcnc.

Chris M