Work with probe

Hello Verser.

Have you considered?

Put an M73 at the beginning of each of the subroutines in macros (e.g., xplus.ngc, xminus.ngc, ...)

That would automatically save the modal stuff. Right now, if the mode was G91 when the user did his probing, it will be set to G90 when done. (Unless there is some other magic taking place that I don't know about.) The same is true of the current F value.

Also:

Should you be setting feed rate mode? Or do you assume that the user will set the feed variables to match what the currently set feed rate mode is?

Also -- (I don't know if this still works, or if it would be a bad practice)

Even though the documentation says to put one subroutine is each file, that is really not a requirement. (At least when I wrote the code, it wasn't a requirement.)

The way it works (or used to) is that the file name is needed to know which file to load into the interpreter. Once the file is loaded, ALL subroutines in the file are accessible. So the file could be named: probe_init. Then if probe_init were called at system startup, all subroutines in the file would be accessible.

That way all of the subroutines could be contained in a single file. Personally, I really don't like having bunches of little files.

Thanks for putting in all of the hard work on this. Aside from the fact that I'm waiting for a connector for my probe, everything seems ready to work.

Regards,

Ken

lerman wrote: Even though the documentation says to put one subroutine is each file, that is really not a requirement. (At least when I wrote the code, it wasn't a requirement.)
The way it works (or used to) is that the file name is needed to know which file to load into the interpreter. Once the file is loaded, ALL subroutines in the file are accessible

That's interesting. Perhaps we need to test it, and if it works, update the docs.
It would make my turning macros a fair bit neater.

Thanks Ken, all your tips are sensible and will be taken on arms,
and yet offer such an update ver.1.0.1 (now you can auto rotate the coordinate system with probe)

Is this new screen on Github yet. I just pulled but it still looks like the older screen.

Ok so I have the right stuff in the right folders now.
I get this error

Am I missing some setup stuff?

Fixed that as well - features was still sitting at 12. :blush: