setup qtplasmac

Great work. If you want to submit a PR to include the work I would be happy to merge it.

If you want to do a PR you would just need to make some minor changes to keep the code consistent with the existing. Also it would be better to rework the exising height_ovr_pressed function so both the GUI buttons and the external Hal pins use the same function rather than having two functions doing the same job.

Hi,
Ok, I tried to make PR. I did it for the first time, so maybe it works.
Martin
 

phillc54 wrote:

Great work. If you want to submit a PR to include the work I would be happy to merge it.

If you want to do a PR you would just need to make some minor changes to keep the code consistent with the existing. Also it would be better to rework the exising height_ovr_pressed function so both the GUI buttons and the external Hal pins use the same function rather than having two functions doing the same job.

fupeama wrote:

Hi,
Ok, I tried to make PR. I did it for the first time, so maybe it works.
Martin

I saw the PR, it looks good, I will test and merge tomorrow.
It would have been nice if you had renamed the pins so they were similar to the existing external pins, something like:
Do you want to add them to the doc or do you want me to.

OK I will rename pin.
something like this?
self.extHeightOvrPlusPin = self.h.newpin('ext_height_ovr_plus', hal.HAL_BIT, hal.HAL_IN)I would prefer you to add the information to the documentation because English is not my native language.

Martin

Great, thanks for doing this. I'll do the docs tomorrow as well.

Thanks for adding code to repo.
If you want, I can try write code for encoder height override too.
Martin