Code cleanup question

More
06 May 2021 03:57 #208062 by cmorley
Replied by cmorley on topic Code cleanup question
C would not have fixed the gtk2 to 3 problem.
Python offers a low barrier to user customizations.

It's a pain we have postponed for as long as we could. Time to bite the bullet.

Or use qtvcp - it can run in python 2 or 3 (havent checked py3 in a couple months though)

Please Log in or Create an account to join the conversation.

More
06 May 2021 07:46 #208076 by newbynobi
Replied by newbynobi on topic Code cleanup question
I may ask Rene to test, if a glade gtk2 panel can be embedded in a gtk3 UI like gmoccapy.
As far as I have tested, it does still work. But we need to maintain then a gtk2.deb for linuxcnc.

Disadvantage is, that actually it is possible to set the theme from a glade panel according ti the one used by the UI, in gtl3 that will not work any more, so the glade panel would have a different design.

Norbert

Please Log in or Create an account to join the conversation.

More
06 May 2021 09:22 #208081 by BeagleBrainz
Replied by BeagleBrainz on topic Code cleanup question
It wasn't a serious suggestion by any stretch of the imagination.

As much as I can't really program I appreciate all the work everyone puts in.
The following user(s) said Thank You: tommylight

Please Log in or Create an account to join the conversation.

More
06 May 2021 19:27 #208150 by gibsonc
Replied by gibsonc on topic Code cleanup question

cmorley wrote: Or use qtvcp - it can run in python 2 or 3 (havent checked py3 in a couple months though)


I thought about this too, but lets be honest Norbert has put a lot of work into gmoccapy which is very successful.

Qt is also subject to this constant commercial / not commercial cat and mouse game that keeps playing out with ever major version like what is happening right now with the 5.1.5 LTS release.

As for using the latest Glade to open the panels, I used 3.22 and yes it works and you can save, but some items are messed up a bit and need fixing, especially with respect to alignment when you convert the table widget to a grid. I actually found it quicker and easier in some cases to just recreate the panel from scratch. Again though I just tried a few items to see what would happen.

Please Log in or Create an account to join the conversation.

More
06 May 2021 22:46 #208164 by cmorley
Replied by cmorley on topic Code cleanup question
To be clear I wasn't suggesting not supporting gtk3 (gmoccapy will use it)
I'm saying supporting py2/gtk2 in the future is futile and there are alternatives right now.
Breaking configs is necessary in this case - and alright with a major release.

I seriously doubt Qt will present any real problem to us.
ans if it does, the community will find a work around. Qt is used a lot in linux.

Please Log in or Create an account to join the conversation.

More
07 May 2021 15:30 #208222 by newbynobi
Replied by newbynobi on topic Code cleanup question
I agree with Chris, we will need to make a hard brake in this case.

Norbert
The following user(s) said Thank You: rodw

Please Log in or Create an account to join the conversation.

More
07 May 2021 17:41 #208240 by rene-dev
Replied by rene-dev on topic Code cleanup question
my gtk3 branch is here:
github.com/rene-dev/linuxcnc/tree/limuxcmc

I have made a lot of progress, gmoccapy and touchy are starting.

we do need to make a cut, cannot support both. user panels only need to be updated if they use stuff that isnt supported anymore. I made very little changes to touchy or gmoccapy glade files.

Rene

Please Log in or Create an account to join the conversation.

More
07 May 2021 18:54 #208244 by rene-dev
Replied by rene-dev on topic Code cleanup question

Please Log in or Create an account to join the conversation.

Moderators: mhaberler
Time to create page: 0.135 seconds
Powered by Kunena Forum