Another plasma component...

rodw wrote: Phill, I had a quick look and it looks awesome. I will try and give it a go when I can.

It would also be good if you could apply Andy's patch on this thread
forum.linuxcnc.org/38-general-linuxcnc-q...ate-from-git?start=0

which fixes this Trajectory planner bug:
github.com/LinuxCNC/linuxcnc/pull/512
Follow the link to Issue 447 for more info on the problem

I think that is about the only thing that is missing from your branch.

Phill, this has now been fixed in 2.8 (master branch) and 2.7 so a rebase with LinuxCNC should solve the problem and avoid the need to work on incorporating the patch Andy shared with Islander261.

Closed #447 via 1fcb261.

A big thanks to the Dev team for finally getting to the bottom of this!

Many thanks
could you tell me how to install these changes?
I humbly ask you sorry but I always have to use the translator and I'm not very practical with git.
regards
Mauro

Tom wrote:

The acceleration issue after reverse run seems to affect only the first cut line, the following lines are not affected. Will have to investigate more.

Yes that is what I found as well. I checked out the rev-run-master2 branch and it showed the same behaviour.

Rod wrote:

Phill, this has now been fixed in 2.8 (master branch) and 2.7 so a rebase with LinuxCNC should solve the problem and avoid the need to work on incorporating the patch Andy shared with Islander261.

This fix has me baffled at the moment. I got a lot of conflicts when I tried to apply Andys patch so I then tried to cherry-pick the individual commits and I also got a lot of conflicts. I have just tried to merge master and get the same conflicts.
It appears that reverse run and the tp fix conflict with each other and it is above my pay grade to fix it (I did try but made a complete hash of it) so it may need robEllenberg to sort it as I think he is the author of both.
In the meantime we need to decide on one of two options until this can be fixed:
1. master with the tp fix + external offsets
2. master before the tp fix + external offsets + reverse run

Cheers, Phill.

Mauro wrote:

could you tell me how to install these changes?

cd into the folder you cloned to
git pull
cd src
make

Cheers, Phill.

phillc54 wrote: It appears that reverse run and the tp fix conflict with each other and it is above my pay grade to fix it (I did try but made a complete hash of it) so it may need robEllenberg to sort it as I think he is the author of both.
In the meantime we need to decide on one of two options until this can be fixed:
1. master with the tp fix + external offsets
2. master before the tp fix + external offsets + reverse run

Cheers, Phill.

My vote would be for the TP fix. The tp bug can affect cut quality, reverse run is more a convenience. Maybe you can make a comment on one of the issues or on the developers mailing list. I think external offsets will be pushed to master soon. Hopefully, they will also look at reverse run. Its been talked about.

The other feature mentioned that may be useful was the state tags branch. This has been suggested to be a possible solution to knowing the original feed rate instead of using remapping. I've looked at the code and have seen the new structure but don't know how you would access it from the component.... Some discussion on Issue 440 here but I could never find out how it might be used.:
github.com/LinuxCNC/linuxcnc/issues/440

Phill, I added a note on Issue 447. Hopefully it will get seen even though the issue is closed....
github.com/LinuxCNC/linuxcnc/issues/447