Materialverter

Ok, I think I got it figured out. I am doing this from the website btw, idk if that makes a difference.

There is no linuxcnc-dev that I see on the github repository. I changed the .comp file under the linuxcnc folder. I am not sure if that was right or not, you can see what I did there though, please let me know if I need to fix it.

How does this get from the master branch to the 2.8 branch? It looks like everything I did was under master?

phillc54 wrote:

Maybe I should put a sticky thread describing this in case others want to contribute code.

I think a sticky is probably a good idea?

OK, I assumed you were doing it from your local repo.
It does all need to be in one commit though, which you can do locally with a squash. I am not sure how that can be achieved via the website.
It may be worthwhile asking the question on the developers email list:
sourceforge.net/projects/emc/lists/emc-developers

phillc54 wrote:

OK, I assumed you were doing it from your local repo.
It does all need to be in one commit though, which you can do locally with a squash. I am not sure how that can be achieved via the website.
It may be worthwhile asking the question on the developers email list:
sourceforge.net/projects/emc/lists/emc-developers

I think I got them all to the same pull request, does it look right, or no?

They are the same PR but there are four commits, ideally it should be one.

I don't think I have the permissions I need from what I see on the interwebs. At any rate, I've reached the max amount of frustration for the evening, and ironically the end of my laptop battery.

needs to be inserted after line 306, or as the screen shot shows:



Evidently I can only have one coding victory per day.

It wont hurt my feelings if you commit the change on my behalf. I'll figure out git another day.

If you do want to try again here is a starting point. I can help you through if I know the answers.

linuxcnc.org/docs/html/code/contributing-to-linuxcnc.html

No rush, you can always close the existing PR and make a new one when you a happy with what you have.

phillc54 wrote:

If you do want to try again here is a starting point. I can help you through if I know the answers.

linuxcnc.org/docs/html/code/contributing-to-linuxcnc.html

No rush, you can always close the existing PR and make a new one when you a happy with what you have.

Ah, yea that seems like a good place to start. Maybe I dont have my profile filled out right... I’ll close the pull request in the morning and try to start again but from the Linux pc. Seems git is happier with terminal commands?

At any rate the lappy is charging, I’ll go at it fresh tomorrow. Thanks as usual!

No worries, its a good learning experience.