A Teensy -> Python Interface Manualmatic MPG/pendant

More
31 Jan 2022 13:03 #233627 by sagreen
The following user(s) said Thank You: fletch

Please Log in or Create an account to join the conversation.

More
31 Jan 2022 13:22 #233628 by fletch
Thank you - how's the code review going?

Please Log in or Create an account to join the conversation.

More
31 Jan 2022 20:10 #233664 by sagreen

Thank you - how's the code review going?


We should jump on a discord chat and walk through it. Havent spent any time in the python code, but looked a bit at the sketch. Nothing big, just a few things that might help you in the future.

Scott...
The following user(s) said Thank You: fletch

Please Log in or Create an account to join the conversation.

More
31 Jan 2022 20:33 #233667 by fletch
That would be great - it took me an hour to squash this this one: github.com/Stutchbury/DisplayUtils/blob/.../DisplayUtils.h#L260

Let me know a convenient time & place.

Please Log in or Create an account to join the conversation.

More
01 Feb 2022 01:40 #233679 by sagreen

That would be great - it took me an hour to squash this this one: github.com/Stutchbury/DisplayUtils/blob/.../DisplayUtils.h#L260

Let me know a convenient time & place.

This is my discord server   discord.gg/DwwXq9mb

Come join, and ping me from there. I'm rudedog on that server.

Scott...

Please Log in or Create an account to join the conversation.

More
01 Feb 2022 12:08 #233706 by fletch
Couple of quick questions:

1. Is there any value in adding an (optional) joystick? I've seen lot of positive views on non-standard pendants but can't recall seeing one on a commercial pendant.

2. I'm looking at making a PCB - anyone interested if I make a few extras?
The following user(s) said Thank You: lomas8

Please Log in or Create an account to join the conversation.

More
02 Feb 2022 21:59 #233838 by sagreen
Phil,

Check out github.com/LennartHennigs/Button2/pull/29

Looks like a nice fix to allow callback functions to exist within a class. Was probably implemented in button2 after you started working on your library.

Scott...

Please Log in or Create an account to join the conversation.

More
02 Feb 2022 23:24 #233843 by sagreen
I created a pull request in your library with the fix for your approval. Works great!

Scott...

Please Log in or Create an account to join the conversation.

More
03 Feb 2022 12:06 #233867 by fletch

Phil,

Check out github.com/LennartHennigs/Button2/pull/29

Looks like a nice fix to allow callback functions to exist within a class. Was probably implemented in button2 after you started working on your library.

Scott...
 

Thanks Scott - I wrote the EncoderButton a few years ago (I just tidied it up for release), so hadn't revisited Lennart's Button2 but this was how I implemented it for my thermostat project -  that was for ESP32 so I didn't/couldn't port it to Arduino.  Teensyduino however...

Please Log in or Create an account to join the conversation.

More
03 Feb 2022 12:15 #233868 by fletch

I created a pull request in your library with the fix for your approval. Works great!

Scott...
 

Brilliant! Thank you very much. I'll pull that straight across and add a formal example. I'm assuming (dangerous) the commented out ' //#define ARDUINO_ARCH_ESP32 1' is superfluous.
Also curious about the 'using' vs 'typedef' - I originally had 'typedef' but at some point moved to 'using' but can't remember why...

Please Log in or Create an account to join the conversation.

Time to create page: 0.110 seconds
Powered by Kunena Forum