Gscreen - a GTK / Glade / Python based screen

More
05 Oct 2012 22:15 #25033 by andypugh
BigJohnT wrote:

Would it make more sense to have a "Save & Quit" button and a "Cancel" button?


I get confused by the existing editor. (I always seem to end up with a dozen orphan editors hiding in the background under Axis).

I would suggest an "Apply" button and a "Quit"

Please Log in or Create an account to join the conversation.

More
05 Oct 2012 22:28 #25034 by BigJohnT
Is there something else you might do after "applying" before quitting?

And yes the TCL editor is confusing to me with the button labels.

John

Please Log in or Create an account to join the conversation.

More
05 Oct 2012 22:59 #25035 by cmorley
save and quit and cancel would be better I think.
or apply and quit.
It should tell you if you have changed but not saved too...

I am working on a different display if the config is for a lathe. it just leaves out the info not pertinent to lathes.
I dont use tool tables so suggestions are welcome.

Please Log in or Create an account to join the conversation.

More
05 Oct 2012 23:02 #25036 by cmorley
The again if the editor is embedded in say gscreen quit doesn't make sense....
Ill finish what I got then think on it...

Please Log in or Create an account to join the conversation.

More
05 Oct 2012 23:17 #25037 by BigJohnT
Save & Close perhaps... but I understand where your coming from as it sounds like it might quit the CNC app as well as the editor. So maybe

Save Changes and close Editor |Yes| the button being the yes part or make it editable. In any case I can only see two actions needed, perhaps three actions... save and close the editor, revert changes, cancel the edit... nothing else makes sense to me.

John

Please Log in or Create an account to join the conversation.

More
05 Oct 2012 23:21 #25038 by BigJohnT
Oh, by embedded like in a tab? Then unsaved changes warning, a revert button and a save button is all that I can see you needing.

John

Please Log in or Create an account to join the conversation.

More
06 Oct 2012 19:09 #25074 by cmorley
buttons for add and delete (a tool)
button for apply changes
button for do not apply

One may need a refresh button since changes to the tool table can happen from mdi / program.
either that or have tool edit gtk poll linuxcnc

Please Log in or Create an account to join the conversation.

More
06 Oct 2012 20:16 #25078 by BigJohnT
Yep I forgot add and delete. Can you poll linuxcnc when a tab is selected? I never could figure out what triggers signals were associated with selecting a tab.

John

Please Log in or Create an account to join the conversation.

More
14 Oct 2012 22:15 - 14 Oct 2012 22:17 #25318 by cmorley
Here is a updated pic:
Attachments:
Last edit: 14 Oct 2012 22:17 by cmorley.

Please Log in or Create an account to join the conversation.

More
14 Oct 2012 22:21 #25320 by cmorley
I think the widget still needs some tweaks. I think it needs to tell linuxcnc to reload the tool table if you set apply.
At the moment it just saves the text changes to the file.
I don't know all the rules about tool tables. It seems that the tcl tooltable had checks for other things ... i'll have to try and decipher more.

This has been pushed to the Gscreen repo if any one wishes to try it.

Please Log in or Create an account to join the conversation.

Time to create page: 0.138 seconds
Powered by Kunena Forum