qtdragon - probing issues
- Roguish
- 
				  
- Offline
- Elite Member
- 
				  
		Less
		More
		
			
	
		- Posts: 297
- Thank you received: 31
			
	
						09 May 2023 14:49		 -  09 May 2023 15:11		#271030
		by Roguish
	
	
		
			
	
	
			 		
													
	
				Replied by Roguish on topic qtdragon - probing issues			
			
				Chris, where are you putting these changes? git branch ????
If I recall correctly, I can just do a 'git pull' to update, then the compile only compiles what has changed.....
 			
					If I recall correctly, I can just do a 'git pull' to update, then the compile only compiles what has changed.....
		Last edit: 09 May 2023 15:11  by Roguish.			
			Please Log in or Create an account to join the conversation.
- cmorley
- Away
- Moderator
- 
				  
		Less
		More
		
			
	
		- Posts: 7230
- Thank you received: 2106
			
	
						09 May 2023 17:02				#271041
		by cmorley
	
	
		
			
	
	
			 		
													
	
				Replied by cmorley on topic qtdragon - probing issues			
			
				git pull
git checkout qtvcp_probe_max_z_fix
					git checkout qtvcp_probe_max_z_fix
		The following user(s) said Thank You: Roguish 	
			Please Log in or Create an account to join the conversation.
- rodw
- 
				 Topic Author Topic Author
- Offline
- Platinum Member
- 
				  
		Less
		More
		
			
	
		- Posts: 11460
- Thank you received: 3843
			
	
						09 May 2023 19:30				#271060
		by rodw
	
	
		
			
				
					
	
	
			 		
													
	
				Replied by rodw on topic qtdragon - probing issues			
			Yes, unless you do a make clean, only changed files are built by make. Because the changes are only to python and .ui files, they don't need compiling so a make finishes up immediately but I always run it just in case.Chris, where are you putting these changes? git branch ????
If I recall correctly, I can just do a 'git pull' to update, then the compile only compiles what has changed.....
		The following user(s) said Thank You: Roguish 	
			Please Log in or Create an account to join the conversation.
- rodw
- 
				 Topic Author Topic Author
- Offline
- Platinum Member
- 
				  
		Less
		More
		
			
	
		- Posts: 11460
- Thank you received: 3843
			
	
						10 May 2023 03:02				#271080
		by rodw
	
	
		
			
	
	
		
	
			 		
													
	
				Replied by rodw on topic qtdragon - probing issues			
			
				Chris, 
I worked this out. Inside probing works correctly if X & Y hints are entered,
If hints are not added it goes a bit crazy for no reason, See the screen dump and video
 
photos.app.goo.gl/SgRoQ9yWaFavzKNB9
There really is no valid reason to do what its doing.
It should never move away from the face to be probed on an inside probe
It should not move towards an already probed surface.
 			
					I worked this out. Inside probing works correctly if X & Y hints are entered,
If hints are not added it goes a bit crazy for no reason, See the screen dump and video
photos.app.goo.gl/SgRoQ9yWaFavzKNB9
There really is no valid reason to do what its doing.
It should never move away from the face to be probed on an inside probe
It should not move towards an already probed surface.
Attachments:
		The following user(s) said Thank You: Roguish 	
			Please Log in or Create an account to join the conversation.
- cmorley
- Away
- Moderator
- 
				  
		Less
		More
		
			
	
		- Posts: 7230
- Thank you received: 2106
			
	
						10 May 2023 10:27				#271097
		by cmorley
	
	
		
			
	
	
			 		
													
	
				Replied by cmorley on topic qtdragon - probing issues			
			
				Great information - thanks Rod.
well here is something interesting:
If you don't add a hint, because of the math, the distance can become a negative value.
The python function expected the value to always be positive.
The first MDI command adds a negative sign, so you end up with two negative signs.
And linuxcnc happy accepts two negative signs, and converts them to a positive number.
And that is why it went the wrong direction on the first move.
I can add error checks for length hints.
					well here is something interesting:
If you don't add a hint, because of the math, the distance can become a negative value.
The python function expected the value to always be positive.
The first MDI command adds a negative sign, so you end up with two negative signs.
And linuxcnc happy accepts two negative signs, and converts them to a positive number.
And that is why it went the wrong direction on the first move.
I can add error checks for length hints.
		The following user(s) said Thank You: Roguish 	
			Please Log in or Create an account to join the conversation.
- rodw
- 
				 Topic Author Topic Author
- Offline
- Platinum Member
- 
				  
		Less
		More
		
			
	
		- Posts: 11460
- Thank you received: 3843
			
	
						10 May 2023 12:11				#271101
		by rodw
	
	
		
			
	
	
			 		
													
	
				Replied by rodw on topic qtdragon - probing issues			
			
				so a case  of two wrongs don't make a right   .
.
This just came to me.
Assuming the direction is positive towards the desired surface to probe (whatever sign that is).
Perhaps if could be solved as follows:
if the calculated start position was negative in relation to the physical start position (eg further away), then the move is truncated by that distance and the current position is deemed the start position.
That should eliminate the initial wrong way move...
Sorry gone cross-eyed writing asciidoc for getting Linuxcnc.... Hope the above makes sense
					 .
.This just came to me.
Assuming the direction is positive towards the desired surface to probe (whatever sign that is).
Perhaps if could be solved as follows:
if the calculated start position was negative in relation to the physical start position (eg further away), then the move is truncated by that distance and the current position is deemed the start position.
That should eliminate the initial wrong way move...
Sorry gone cross-eyed writing asciidoc for getting Linuxcnc.... Hope the above makes sense
		The following user(s) said Thank You: Roguish 	
			Please Log in or Create an account to join the conversation.
- rodw
- 
				 Topic Author Topic Author
- Offline
- Platinum Member
- 
				  
		Less
		More
		
			
	
		- Posts: 11460
- Thank you received: 3843
			
	
						10 May 2023 12:13				#271102
		by rodw
	
	
		
			
	
	
			 		
													
	
				Replied by rodw on topic qtdragon - probing issues			
			
				I suspect this also explains why I could not probe small holes...			
					
		The following user(s) said Thank You: Roguish 	
			Please Log in or Create an account to join the conversation.
- Roguish
- 
				  
- Offline
- Elite Member
- 
				  
		Less
		More
		
			
	
		- Posts: 297
- Thank you received: 31
			
	
						10 May 2023 14:43				#271108
		by Roguish
	
	
		
			
	
			
			 		
													
	
				Replied by Roguish on topic qtdragon - probing issues			
			
				Chris and Rod,
well, looks like it's getting better.
What ever the outcome is, please, please include good documentation so users know what to do, and what not to do. Probes are expensive.....
 			
					well, looks like it's getting better.
What ever the outcome is, please, please include good documentation so users know what to do, and what not to do. Probes are expensive.....
Please Log in or Create an account to join the conversation.
- cmorley
- Away
- Moderator
- 
				  
		Less
		More
		
			
	
		- Posts: 7230
- Thank you received: 2106
			
	
						10 May 2023 21:21				#271132
		by cmorley
	
	
		
			
	
			
			 		
													
	
				Replied by cmorley on topic qtdragon - probing issues			
			
				Could you write a small sample of how the docs would be most helpful for use?
There are help files but they probably lack detail.
					There are help files but they probably lack detail.
Please Log in or Create an account to join the conversation.
- andypugh
- 
				  
- Offline
- Moderator
- 
				  
		Less
		More
		
			
	
		- Posts: 19677
- Thank you received: 4554
			
	
						11 May 2023 11:59				#271158
		by andypugh
	
	
		
			
	
			
			 		
													
	
				Replied by andypugh on topic qtdragon - probing issues			
			
				Does this probing system revert to machine units before probing? I just published a fix to probe-screen-ng related to this.			
					Please Log in or Create an account to join the conversation.
		Moderators: cmorley	
		Time to create page: 0.165 seconds	
 
													