Error in tool_offsetview.py

More
07 Jan 2024 22:53 #290157 by MarkoPolo
OK.
Personally, I added a "go to zero" macro button for the A axis, so I don't have a problem with it. I was thinking generally to improve qtdragon in this matter
Fields with axis letters take up a lot of space, but they don't do much work, so maybe it would be worth thinking about some useful functions for them.

Please Log in or Create an account to join the conversation.

More
07 Jan 2024 23:04 #290161 by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
yes I've thought about different ideas about that. ie
if the axis letters were axis selection, then you could have less jog button (only two + and -) which would leave room for buttons such as 'move selected axis to zero' etc.

Some would like it some would not. Hopefully some adventurous people will try some of those ideas out - Qtvcp is made to be modified by power users.

I'm just too busy trying to catch up other software projects.

Please Log in or Create an account to join the conversation.

More
29 Mar 2024 21:13 - 29 Mar 2024 21:32 #297143 by MarkoPolo
Hi Cmorley
When I press any value in the offset table, an error occurs. It seems to be a problem with commas, if someone has dots in this place it probably works fine.
(Probably some recent changes, because it was working fine before.)
If I change float to str in the "origin_offsetview.py" file, it works fine, but I'm not sure whether this solution is correct.

modification:
in another function I see that it is "'PRELOAD:text", and in this form it works fine.
Attachments:
Last edit: 29 Mar 2024 21:32 by MarkoPolo.

Please Log in or Create an account to join the conversation.

More
29 Mar 2024 22:33 #297157 by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
what version of python does your system use?

This looks like the change that might cause the error:

github.com/LinuxCNC/linuxcnc/commit/8d9d...dcf184470457c97cdbb5

Please Log in or Create an account to join the conversation.

More
29 Mar 2024 23:20 - 29 Mar 2024 23:21 #297163 by MarkoPolo
I have python 3.7.3 on the system with the problem

I checked on another system debian 12 and pytchon 3.11.2 works fine, but the tool table has dots as in the screenshot.
Linuxcnc versions are identical in both systems.
Attachments:
Last edit: 29 Mar 2024 23:21 by MarkoPolo.

Please Log in or Create an account to join the conversation.

More
30 Mar 2024 06:42 #297194 by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
Ok I think I fixed the locale problem.
Also did some work with switching the axis labels to axis tool buttons for setting reference.
This allowed bringing back the 'go to zero' buttons for the 4th and 5th axes.

Now we need to figure out what to do with the reference buttons for XYZ...
The following user(s) said Thank You: tommylight

Please Log in or Create an account to join the conversation.

More
30 Mar 2024 19:05 #297227 by MarkoPolo
Yes, the tool table now works properly.
I see that you made buttons from the fields on the left side of DRO, I like it, I wrote about it a few posts earlier.
The "go to zero" buttons appeared in place of the "ref" buttons, previously they were in the place of the home and tool buttons, but "go to zero" is not often used, so I thought to move these buttons to the newly created menu and leave the ref buttons as they are. Additionally, it would be nice if users could easily add their macros to the button menu of individual axes.
These are just my ideas.

Please Log in or Create an account to join the conversation.

More
31 Mar 2024 00:14 #297248 by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
-oh good about locale.
-Yes I did the change based on your discussion.
-The ref buttons are redundant with the new axis selection buttons.
- yes could make all the reference buttons into macro buttons I suppose.

Please Log in or Create an account to join the conversation.

More
31 Mar 2024 11:54 #297272 by MarkoPolo
Have you thought about something like this screenshot?
 
Attachments:

Please Log in or Create an account to join the conversation.

Moderators: cmorley
Time to create page: 0.133 seconds
Powered by Kunena Forum